Some minor cleanup

src/lib.rs

@@ -20,7 +20,7 @@ use rssink::Sink;
 use rsfilesink::FileSink;
 
 use std::os::raw::c_void;
-use libc::{c_char};
+use libc::c_char;
 use std::ffi::CString;
 
 extern "C" {

src/rsfilesrc.rs

@@ -67,10 +67,10 @@ impl Source for FileSrc {
     }
 
     fn get_uri(&self) -> Option<String> {
-        match self.location {
+        self.location.as_ref()
-            None => None,
+            .map(|l| Url::from_file_path(l).ok())
-            Some(ref location) => Url::from_file_path(&location).map(|u| u.into_string()).ok()
+            .and_then(|i| i) // join()
-        }
+            .map(|u| u.into_string())
     }
 
     fn is_seekable(&self) -> bool {
@@ -78,12 +78,11 @@ impl Source for FileSrc {
     }
 
     fn get_size(&self) -> u64 {
-        match self.file {
+        self.file.as_ref()
-            None => return u64::MAX,
+            .map(|f| f.metadata().ok())
-            Some(ref f) => {
+            .and_then(|i| i) // join()
-                return f.metadata().map(|m| m.len()).unwrap_or(u64::MAX);
+            .map(|m| m.len())
-            },
+            .unwrap_or(u64::MAX)
-        }
     }
 
     fn start(&mut self) -> bool {

src/rshttpsrc.rs

@@ -142,7 +142,7 @@ impl Source for HttpSrc {
     }
 
     fn get_uri(&self) -> Option<String> {
-        self.url.clone().map(|u| u.into_string())
+        self.url.as_ref().map(|u| String::from(u.as_str()))
     }
 
     fn is_seekable(&self) -> bool {

src/rssource.c

@@ -4,7 +4,6 @@
 #include <stdint.h>
 
 typedef struct {
-  gchar *name;
   gchar *long_name;
   gchar *description;
   gchar *classification;
@@ -305,7 +304,6 @@ gst_rs_source_register (GstPlugin * plugin, const gchar *name, const gchar * lon
   ElementData *data;
 
   data = g_new0 (ElementData, 1);
-  data->name = g_strdup (name);
   data->long_name = g_strdup (long_name);
   data->description = g_strdup (description);
   data->classification = g_strdup (classification);