mirror of
https://github.com/woodpecker-ci/woodpecker.git
synced 2024-06-02 21:49:25 +00:00
52d3652f2e
Use IDs of the forge to fetch repositories instead of their names and owner names. This improves handling of renamed and transferred repos.
TODO
- [ ] try to support as many forges as possible
- [x] Gogs (no API)
- [ ] Bitbucket Server
- [x] Coding (no API?)
- [x] update repo every time it is fetched or received from the forge
- [x] if repo remote IDs are not available, use owner / name to get it
- [x] handle redirections (redirect a renamed repo to its new path)
- [x] ~~pull all repos once during migration to update ID (?)~~ issue fixed by on-demand loading of remote IDs
- [x] handle redirections in web UI
- [ ] improve handling of hooks after a repo was renamed (currently it checks for a redirection to the repo)
- [x] tests
- [x] `UNIQUE` constraint for remote IDs after migration shouldn't work (all repos have an empty string as remote ID)
close #854
close #648 partial
close https://codeberg.org/Codeberg-CI/feedback/issues/46
Possible follow-up PRs
- apply the same scheme on everything fetched from the remote (currently only users)
Co-authored-by: 6543 <6543@obermui.de>
48 lines
1.6 KiB
Go
48 lines
1.6 KiB
Go
// Copyright 2022 Woodpecker Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package datastore
|
|
|
|
import (
|
|
"github.com/woodpecker-ci/woodpecker/server/model"
|
|
"xorm.io/xorm"
|
|
)
|
|
|
|
func (s storage) GetRedirection(fullName string) (*model.Redirection, error) {
|
|
sess := s.engine.NewSession()
|
|
defer sess.Close()
|
|
return s.getRedirection(sess, fullName)
|
|
}
|
|
|
|
func (s storage) getRedirection(e *xorm.Session, fullName string) (*model.Redirection, error) {
|
|
repo := new(model.Redirection)
|
|
return repo, wrapGet(e.Where("repo_full_name = ?", fullName).Get(repo))
|
|
}
|
|
|
|
func (s storage) CreateRedirection(redirect *model.Redirection) error {
|
|
sess := s.engine.NewSession()
|
|
defer sess.Close()
|
|
return s.createRedirection(sess, redirect)
|
|
}
|
|
|
|
func (s storage) createRedirection(e *xorm.Session, redirect *model.Redirection) error {
|
|
// only Insert set auto created ID back to object
|
|
_, err := e.Insert(redirect)
|
|
return err
|
|
}
|
|
|
|
func (s storage) HasRedirectionForRepo(repoID int64, fullName string) (bool, error) {
|
|
return s.engine.Where("repo_id = ? ", repoID).And("repo_full_name = ?", fullName).Get(new(model.Redirection))
|
|
}
|