mirrors/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2024-05-20 09:18:15 +00:00
Code Issues Projects Releases Wiki Activity

refactor: use switch-case not try-err (#1112)

Browse source
This commit is contained in:
6543 2022-08-15 14:39:08 +02:00 committed by GitHub
parent 5a945c10e9
commit a46723334b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
pipeline/frontend/yaml/constraint/constraint.go
View file

@ -97,32 +97,24 @@ func (when *When) IsLocal() bool {
}
func (when *When) UnmarshalYAML(value *yaml.Node) error {
unmarshelAsList := func() error {
lst := []Constraint{}
err := value.Decode(&lst)
if err != nil {
switch value.Kind {
case yaml.SequenceNode:
if err := value.Decode(&when.Constraints); err != nil {
return err
}
when.Constraints = lst
return nil
}
unmarshelAsDict := func() error {
case yaml.MappingNode:
c := Constraint{}
err := value.Decode(&c)
if err != nil {
if err := value.Decode(&c); err != nil {
return err
}
when.Constraints = append(when.Constraints, c)
return nil
default:
return fmt.Errorf("not supported yaml kind: %v", value.Kind)
}
err := unmarshelAsList()
if err != nil {
err = unmarshelAsDict()
}
return err
return nil
}
// Match returns true if all constraints match the given input. If a single