From 9ae9e03b9d0fdee80eef0f5bba46a6d4e1846a24 Mon Sep 17 00:00:00 2001 From: Corry Haines Date: Wed, 4 Jan 2023 15:42:57 -0800 Subject: [PATCH] Re-use page for interaction query (#351) Original code caused the query on timeline to issue twice. Once to satisfy the interactions lookup (which had no LIMIT) and then again for the page (which had a LIMIT 25). Presumably we want interactions for the paginated events, especially since the un-LIMITed query would become extremely inefficient. --- activities/views/timelines.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/activities/views/timelines.py b/activities/views/timelines.py index 855a066..0f3e7c1 100644 --- a/activities/views/timelines.py +++ b/activities/views/timelines.py @@ -25,14 +25,15 @@ class Home(TemplateView): events = TimelineService(self.request.identity).home() paginator = Paginator(events, 25) page_number = self.request.GET.get("page") + event_page = paginator.get_page(page_number) context = { "interactions": PostInteraction.get_event_interactions( - events, + event_page, self.request.identity, ), "current_page": "home", "allows_refresh": True, - "page_obj": paginator.get_page(page_number), + "page_obj": event_page, "form": self.form_class(request=self.request), } return context