mirror of
https://git.pleroma.social/pleroma/pleroma.git
synced 2024-05-18 01:32:41 +00:00
ede414094f
Rich Media parsing was previously handled on-demand with a 2 second HTTP request timeout and retained only in Cachex. Every time a Pleroma instance is restarted it will have to request and parse the data for each status with a URL detected. When fetching a batch of statuses they were processed in parallel to attempt to keep the maximum latency at 2 seconds, but often resulted in a timeline appearing to hang during loading due to a URL that could not be successfully reached. URLs which had images links that expire (Amazon AWS) were parsed and inserted with a TTL to ensure the image link would not break. Rich Media data is now cached in the database and fetched asynchronously. Cachex is used as a read-through cache. When the data becomes available we stream an update to the clients. If the result is returned quickly the experience is almost seamless. Activities were already processed for their Rich Media data during ingestion to warm the cache, so users should not normally encounter the asynchronous loading of the Rich Media data. Implementation notes: - The async worker is a Task with a globally unique process name to prevent duplicate processing of the same URL - The Task will attempt to fetch the data 3 times with increasing sleep time between attempts - The HTTP request obeys the default HTTP request timeout value instead of 2 seconds - URLs that cannot be successfully parsed due to an unexpected error receives a negative cache entry for 15 minutes - URLs that fail with an expected error will receive a negative cache with no TTL - Activities that have no detected URLs insert a nil value in the Cachex :scrubber_cache so we do not repeat parsing the object content with Floki every time the activity is rendered - Expiring image URLs are handled with an Oban job - There is no automatic cleanup of the Rich Media data in the database, but it is safe to delete at any time - The post draft/preview feature makes the URL processing synchronous so the rendered post preview will have an accurate rendering Overall performance of timelines and creating new posts which contain URLs is greatly improved.
81 lines
2.1 KiB
Elixir
81 lines
2.1 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.HTML do
|
|
# Scrubbers are compiled on boot so they can be configured in OTP releases
|
|
# @on_load :compile_scrubbers
|
|
|
|
def compile_scrubbers do
|
|
dir = Path.join(:code.priv_dir(:pleroma), "scrubbers")
|
|
|
|
dir
|
|
|> Pleroma.Utils.compile_dir()
|
|
|> case do
|
|
{:error, _errors, _warnings} ->
|
|
raise "Compiling scrubbers failed"
|
|
|
|
{:ok, _modules, _warnings} ->
|
|
:ok
|
|
end
|
|
end
|
|
|
|
defp get_scrubbers(scrubber) when is_atom(scrubber), do: [scrubber]
|
|
defp get_scrubbers(scrubbers) when is_list(scrubbers), do: scrubbers
|
|
defp get_scrubbers(_), do: [Pleroma.HTML.Scrubber.Default]
|
|
|
|
def get_scrubbers do
|
|
Pleroma.Config.get([:markup, :scrub_policy])
|
|
|> get_scrubbers
|
|
end
|
|
|
|
def filter_tags(html, nil) do
|
|
filter_tags(html, get_scrubbers())
|
|
end
|
|
|
|
def filter_tags(html, scrubbers) when is_list(scrubbers) do
|
|
Enum.reduce(scrubbers, html, fn scrubber, html ->
|
|
filter_tags(html, scrubber)
|
|
end)
|
|
end
|
|
|
|
def filter_tags(html, scrubber) do
|
|
{:ok, content} = FastSanitize.Sanitizer.scrub(html, scrubber)
|
|
content
|
|
end
|
|
|
|
def filter_tags(html), do: filter_tags(html, nil)
|
|
def strip_tags(html), do: filter_tags(html, FastSanitize.Sanitizer.StripTags)
|
|
|
|
def ensure_scrubbed_html(
|
|
content,
|
|
scrubbers,
|
|
fake,
|
|
callback
|
|
) do
|
|
content =
|
|
content
|
|
|> filter_tags(scrubbers)
|
|
|> callback.()
|
|
|
|
if fake do
|
|
{:ignore, content}
|
|
else
|
|
{:commit, content}
|
|
end
|
|
end
|
|
|
|
@spec extract_first_external_url_from_object(Pleroma.Object.t()) :: String.t() | nil
|
|
def extract_first_external_url_from_object(%{data: %{"content" => content}})
|
|
when is_binary(content) do
|
|
content
|
|
|> Floki.parse_fragment!()
|
|
|> Floki.find("a:not(.mention,.hashtag,.attachment,[rel~=\"tag\"])")
|
|
|> Enum.take(1)
|
|
|> Floki.attribute("href")
|
|
|> Enum.at(0)
|
|
end
|
|
|
|
def extract_first_external_url_from_object(_), do: nil
|
|
end
|