From b75336ce788bb3bbda9f5e4588d6bdf957daf956 Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Sat, 7 Nov 2020 18:35:55 +0800 Subject: [PATCH] Use JSON notation for CMD's arguments in Dockerfile MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reference - Best practices for writing Dockerfiles: - https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#cmd > CMD should almost always be used in the form of CMD ["executable","param1", "param2"…] --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 33671c7..a571dac 100644 --- a/Dockerfile +++ b/Dockerfile @@ -15,4 +15,4 @@ WORKDIR /src/ RUN apk --no-cache add pcre-dev sqlite-dev COPY --from=nim /src/nitter/nitter /src/nitter/start.sh /src/nitter/nitter.conf ./ COPY --from=nim /src/nitter/public ./public -CMD ./start.sh +CMD ["./start.sh"]