From 82fe5d8b784be600c53f4393cedadfb7a63844d7 Mon Sep 17 00:00:00 2001 From: Zed Date: Sun, 8 Nov 2020 00:41:12 +0100 Subject: [PATCH] Make bidirectional support a preference Fixes #270 --- src/prefs_impl.nim | 3 +++ src/sass/tweet/_base.scss | 5 +++++ src/views/tweet.nim | 6 +++++- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/prefs_impl.nim b/src/prefs_impl.nim index 21fec25..448de5d 100644 --- a/src/prefs_impl.nim +++ b/src/prefs_impl.nim @@ -88,6 +88,9 @@ genPrefs: stickyProfile(checkbox, true): "Make profile sidebar stick to top" + bidiSupport(checkbox, false): + "Support bidirectional text (makes clicking on tweets harder)" + hideTweetStats(checkbox, false): "Hide tweet stats (replies, retweets, likes)" diff --git a/src/sass/tweet/_base.scss b/src/sass/tweet/_base.scss index e9012a1..8841657 100644 --- a/src/sass/tweet/_base.scss +++ b/src/sass/tweet/_base.scss @@ -20,6 +20,11 @@ font-family: $font_3; line-height: 1.4em; pointer-events: all; + display: inline; +} + +.tweet-bidi { + display: block !important; } .tweet-header { diff --git a/src/views/tweet.nim b/src/views/tweet.nim index 17bcd98..c5d973c 100644 --- a/src/views/tweet.nim +++ b/src/views/tweet.nim @@ -299,7 +299,11 @@ proc renderTweet*(tweet: Tweet; prefs: Prefs; path: string; class=""; index=0; (tweet.reply.len > 1 or tweet.reply[0] != tweet.profile.username): renderReply(tweet) - tdiv(class="tweet-content media-body", dir="auto"): + var tweetClass = "tweet-content media-body" + if prefs.bidiSupport: + tweetClass &= " tweet-bidi" + + tdiv(class=tweetClass, dir="auto"): verbatim replaceUrl(tweet.text, prefs) & renderLocation(tweet) if tweet.attribution.isSome: