mirror of
https://github.com/LemmyNet/lemmy.git
synced 2024-06-01 08:38:05 +00:00
35cbae61bc
* Respond directly with LemmyError Instrument Perform implementations for more precise traces Use ApiError to format JSON errors when messages are present Keep SpanTrace output in LemmyError Display impl * Hide SpanTrace debug output from LemmyError * Don't log when entering spans, only when leaving * Update actix-web * Update actix-rt * Add newline after error info in LemmyError Display impl * Propogate span information to blocking operations * Instrument apub functions * Use skip_all for more instrument attributes, don't skip 'self' in some api actions * Make message a static string * Send proper JSON over websocket * Add 'message' to LemmyError display if present * Use a quieter root span builder, don't pretty-print logs * Keep passwords and emails out of logs * Re-enable logging Login * Instrument feeds * Emit our own errors * Move error log after status code recording * Make Sensitive generic over the inner type * Remove line that logged secrets
86 lines
3 KiB
Rust
86 lines
3 KiB
Rust
use actix_web::{http::StatusCode, ResponseError};
|
|
use tracing::Span;
|
|
use tracing_actix_web::RootSpanBuilder;
|
|
|
|
// Code in this module adapted from DefaultRootSpanBuilder
|
|
// https://github.com/LukeMathWalker/tracing-actix-web/blob/main/src/root_span_builder.rs
|
|
// and root_span!
|
|
// https://github.com/LukeMathWalker/tracing-actix-web/blob/main/src/root_span_macro.rs
|
|
|
|
pub struct QuieterRootSpanBuilder;
|
|
|
|
impl RootSpanBuilder for QuieterRootSpanBuilder {
|
|
fn on_request_start(request: &actix_web::dev::ServiceRequest) -> Span {
|
|
let request_id = tracing_actix_web::root_span_macro::private::get_request_id(request);
|
|
|
|
tracing::info_span!(
|
|
"HTTP request",
|
|
http.method = %request.method(),
|
|
http.scheme = request.connection_info().scheme(),
|
|
http.host = %request.connection_info().host(),
|
|
http.target = %request.uri().path(),
|
|
http.status_code = tracing::field::Empty,
|
|
otel.kind = "server",
|
|
otel.status_code = tracing::field::Empty,
|
|
trace_id = tracing::field::Empty,
|
|
request_id = %request_id,
|
|
exception.message = tracing::field::Empty,
|
|
// Not proper OpenTelemetry, but their terminology is fairly exception-centric
|
|
exception.details = tracing::field::Empty,
|
|
)
|
|
}
|
|
|
|
fn on_request_end<B>(
|
|
span: tracing::Span,
|
|
outcome: &Result<actix_web::dev::ServiceResponse<B>, actix_web::Error>,
|
|
) {
|
|
match &outcome {
|
|
Ok(response) => {
|
|
if let Some(error) = response.response().error() {
|
|
// use the status code already constructed for the outgoing HTTP response
|
|
handle_error(span, response.status(), error.as_response_error());
|
|
} else {
|
|
let code: i32 = response.response().status().as_u16().into();
|
|
span.record("http.status_code", &code);
|
|
span.record("otel.status_code", &"OK");
|
|
}
|
|
}
|
|
Err(error) => {
|
|
let response_error = error.as_response_error();
|
|
handle_error(span, response_error.status_code(), response_error);
|
|
}
|
|
};
|
|
}
|
|
}
|
|
|
|
fn handle_error(span: Span, status_code: StatusCode, response_error: &dyn ResponseError) {
|
|
let code: i32 = status_code.as_u16().into();
|
|
|
|
span.record("http.status_code", &code);
|
|
|
|
if status_code.is_client_error() {
|
|
span.record("otel.status_code", &"OK");
|
|
} else {
|
|
span.record("otel.status_code", &"ERROR");
|
|
}
|
|
|
|
// pre-formatting errors is a workaround for https://github.com/tokio-rs/tracing/issues/1565
|
|
let display_error = format!("{}", response_error);
|
|
let debug_error = format!("{:?}", response_error);
|
|
|
|
tracing::info_span!(
|
|
parent: None,
|
|
"Error encountered while processing the incoming HTTP request"
|
|
)
|
|
.in_scope(|| {
|
|
if status_code.is_client_error() {
|
|
tracing::warn!("{}\n{}", display_error, debug_error);
|
|
} else {
|
|
tracing::error!("{}\n{}", display_error, debug_error);
|
|
}
|
|
});
|
|
|
|
span.record("exception.message", &tracing::field::display(display_error));
|
|
span.record("exception.details", &tracing::field::display(debug_error));
|
|
}
|