diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 08a8c40171..743f0e21c3 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -26,7 +26,7 @@ variables: # to change any part of the string of the image you want. ### FEDORA_TAG: '2022-03-14.0' - INDENT_TAG: '2021-10-04.0' + INDENT_TAG: '2022-03-07.1' WINDOWS_TAG: "2022-03-14.0" GST_UPSTREAM_REPO: 'gstreamer/gstreamer' @@ -155,6 +155,7 @@ fedora amd64 docker: FDO_REPO_SUFFIX: "$INDENT_AMD64_SUFFIX" FDO_DISTRIBUTION_TAG: "$INDENT_TAG-$GST_UPSTREAM_BRANCH" FDO_DISTRIBUTION_PACKAGES: 'curl indent git findutils' + FDO_DISTRIBUTION_EXEC: 'ci/docker/indent/prepare.sh' gst-indent amd64 docker: extends: @@ -255,17 +256,8 @@ gst indent: - job: 'gst-indent amd64 docker' artifacts: false script: - # man indent. grep RETURN VALUE, grab a beer on my behalf... - - indent --version || true - - ./scripts/gst-indent-all - - | - if git diff --quiet -- ':!subprojects/gst-integration-testsuites/medias' .; then - echo "Code is properly formatted" - else - git diff --color=always -- ':!subprojects/gst-integration-testsuites/medias' . - echo 'style diverges, please run gst-indent first' - exit 1 - fi + - ./scripts/check-format-c + - ./scripts/format-csharp --check rules: # Don't check indentation on post merge pipelines - if: '$CI_PROJECT_NAMESPACE == "gstreamer" && $CI_COMMIT_BRANCH == $GST_UPSTREAM_BRANCH' diff --git a/ci/docker/indent/prepare.sh b/ci/docker/indent/prepare.sh new file mode 100755 index 0000000000..b8c15042c1 --- /dev/null +++ b/ci/docker/indent/prepare.sh @@ -0,0 +1,15 @@ +set -e +set -x +# Install dotnet-format +apt update -yqq +apt install -y gnupg apt-transport-https +curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microsoft.asc.gpg +mv microsoft.asc.gpg /etc/apt/trusted.gpg.d/ +curl -O https://packages.microsoft.com/config/debian/9/prod.list +mv prod.list /etc/apt/sources.list.d/microsoft-prod.list +chown root:root /etc/apt/trusted.gpg.d/microsoft.asc.gpg +chown root:root /etc/apt/sources.list.d/microsoft-prod.list +apt update -yqq +apt install -y dotnet-sdk-5.0 +dotnet tool install --global dotnet-format +ln -s ~/.dotnet/tools/dotnet-format /usr/local/bin/dotnet-format diff --git a/meson.build b/meson.build index 0543316e11..b1b906acd6 100644 --- a/meson.build +++ b/meson.build @@ -450,6 +450,19 @@ if orc_subproject.found() and orc_update_targets.length() > 0 alias_target('update-orc-dist', orc_update_targets) endif +dotnet_format = find_program('dotnet-format', required: false) +if dotnet_format.found() + run_target('csharp_format_check', + command: [join_paths(meson.current_source_dir(), 'scripts', 'format-chsharp'), + '--check' + ], + ) + run_target('csharp_format_apply', + command: [join_paths(meson.current_source_dir(), 'scripts', 'format-chsharp'), + ], + ) +endif + summary({ 'gstreamer-full': building_full, }, section: 'Build options', bool_yn: true, list_sep: ' ') diff --git a/scripts/check-format-c b/scripts/check-format-c new file mode 100755 index 0000000000..61c2b5c1e0 --- /dev/null +++ b/scripts/check-format-c @@ -0,0 +1,16 @@ +#!/bin/bash +set -e + +CUR_DIR="$( cd -P "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" + +indent --version || true + +$CUR_DIR/gst-indent-all + +if git diff --quiet -- ':!subprojects/gst-integration-testsuites/medias' .; then + echo "Code is properly formatted" +else + git diff --color=always -- ':!subprojects/gst-integration-testsuites/medias' . +echo 'style diverges, please run gst-indent first' + exit 1 +fi diff --git a/scripts/format-csharp b/scripts/format-csharp new file mode 100755 index 0000000000..974ce555a4 --- /dev/null +++ b/scripts/format-csharp @@ -0,0 +1,4 @@ +#!/bin/bash +set -e + +dotnet-format subprojects/gstreamer-sharp/gstreamer-sharp.sln --include sources/custom/\*.cs $@ diff --git a/subprojects/gstreamer-sharp/.editorconfig b/subprojects/gstreamer-sharp/.editorconfig new file mode 100644 index 0000000000..580e97d202 --- /dev/null +++ b/subprojects/gstreamer-sharp/.editorconfig @@ -0,0 +1,201 @@ +# Remove the line below if you want to inherit .editorconfig settings from higher directories +root = true + +# C# files +[**/custom/*.cs] + +#### Core EditorConfig Options #### + +# Indentation and spacing +indent_size = 4 +indent_style = tab +tab_width = 4 + +# New line preferences +end_of_line = lf +insert_final_newline = false + +# Line lenght +max_line_length = 120 + +#### .NET Coding Conventions #### + +# Organize usings +dotnet_separate_import_directive_groups = false +dotnet_sort_system_directives_first = false + +# this. and Me. preferences +dotnet_style_qualification_for_event = false:silent +dotnet_style_qualification_for_field = false:silent +dotnet_style_qualification_for_method = false:silent +dotnet_style_qualification_for_property = false:silent + +# Language keywords vs BCL types preferences +dotnet_style_predefined_type_for_locals_parameters_members = true:silent +dotnet_style_predefined_type_for_member_access = true:silent + +# Parentheses preferences +dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent +dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent +dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent +dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent + +# Modifier preferences +dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent + +# Expression-level preferences +dotnet_style_coalesce_expression = true:suggestion +dotnet_style_collection_initializer = true:suggestion +dotnet_style_explicit_tuple_names = true:suggestion +dotnet_style_null_propagation = true:suggestion +dotnet_style_object_initializer = true:suggestion +dotnet_style_prefer_auto_properties = true:silent +dotnet_style_prefer_compound_assignment = true:suggestion +dotnet_style_prefer_conditional_expression_over_assignment = true:silent +dotnet_style_prefer_conditional_expression_over_return = true:silent +dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion +dotnet_style_prefer_inferred_tuple_names = true:suggestion +dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion +dotnet_style_prefer_simplified_interpolation = true:suggestion + +# Field preferences +dotnet_style_readonly_field = true:suggestion + +# Parameter preferences +dotnet_code_quality_unused_parameters = all:suggestion + +#### C# Coding Conventions #### + +# var preferences +csharp_style_var_elsewhere = false:silent +csharp_style_var_for_built_in_types = false:silent +csharp_style_var_when_type_is_apparent = false:silent + +# Expression-bodied members +csharp_style_expression_bodied_accessors = true:silent +csharp_style_expression_bodied_constructors = false:silent +csharp_style_expression_bodied_indexers = true:silent +csharp_style_expression_bodied_lambdas = true:silent +csharp_style_expression_bodied_local_functions = false:silent +csharp_style_expression_bodied_methods = false:silent +csharp_style_expression_bodied_operators = false:silent +csharp_style_expression_bodied_properties = true:silent + +# Pattern matching preferences +csharp_style_pattern_matching_over_as_with_null_check = true:suggestion +csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion +csharp_style_prefer_switch_expression = true:suggestion + +# Null-checking preferences +csharp_style_conditional_delegate_call = true:suggestion + +# Modifier preferences +csharp_prefer_static_local_function = true:suggestion +csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:silent + +# Code-block preferences +csharp_prefer_braces = true:silent +csharp_prefer_simple_using_statement = true:suggestion + +# Expression-level preferences +csharp_prefer_simple_default_expression = true:suggestion +csharp_style_deconstructed_variable_declaration = true:suggestion +csharp_style_inlined_variable_declaration = true:suggestion +csharp_style_pattern_local_over_anonymous_function = true:suggestion +csharp_style_prefer_index_operator = true:suggestion +csharp_style_prefer_range_operator = true:suggestion +csharp_style_throw_expression = true:suggestion +csharp_style_unused_value_assignment_preference = discard_variable:suggestion +csharp_style_unused_value_expression_statement_preference = discard_variable:silent + +# 'using' directive preferences +csharp_using_directive_placement = outside_namespace:silent + +#### C# Formatting Rules #### + +# New line preferences +csharp_new_line_before_catch = true +csharp_new_line_before_else = true +csharp_new_line_before_finally = true +csharp_new_line_before_members_in_anonymous_types = true +csharp_new_line_before_members_in_object_initializers = true +csharp_new_line_before_open_brace = none +csharp_new_line_between_query_expression_clauses = true + +# Indentation preferences +csharp_indent_block_contents = true +csharp_indent_braces = false +csharp_indent_case_contents = true +csharp_indent_case_contents_when_block = true +csharp_indent_labels = one_less_than_current +csharp_indent_switch_labels = true + +# Space preferences +csharp_space_after_cast = false +csharp_space_after_colon_in_inheritance_clause = true +csharp_space_after_comma = true +csharp_space_after_dot = false +csharp_space_after_keywords_in_control_flow_statements = true +csharp_space_after_semicolon_in_for_statement = true +csharp_space_around_binary_operators = before_and_after +csharp_space_around_declaration_statements = false +csharp_space_before_colon_in_inheritance_clause = true +csharp_space_before_comma = false +csharp_space_before_dot = false +csharp_space_before_open_square_brackets = false +csharp_space_before_semicolon_in_for_statement = false +csharp_space_between_empty_square_brackets = false +csharp_space_between_method_call_empty_parameter_list_parentheses = false +csharp_space_between_method_call_name_and_opening_parenthesis = false +csharp_space_between_method_call_parameter_list_parentheses = false +csharp_space_between_method_declaration_empty_parameter_list_parentheses = false +csharp_space_between_method_declaration_name_and_open_parenthesis = false +csharp_space_between_method_declaration_parameter_list_parentheses = false +csharp_space_between_parentheses = false +csharp_space_between_square_brackets = false + +# Wrapping preferences +csharp_preserve_single_line_blocks = true +csharp_preserve_single_line_statements = true + +#### Naming styles #### + +# Naming rules + +dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion +dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface +dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i + +dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion +dotnet_naming_rule.types_should_be_pascal_case.symbols = types +dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case + +dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion +dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members +dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case + +# Symbol specifications + +dotnet_naming_symbols.interface.applicable_kinds = interface +dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected +dotnet_naming_symbols.interface.required_modifiers = + +dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum +dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected +dotnet_naming_symbols.types.required_modifiers = + +dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method +dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected +dotnet_naming_symbols.non_field_members.required_modifiers = + +# Naming styles + +dotnet_naming_style.pascal_case.required_prefix = +dotnet_naming_style.pascal_case.required_suffix = +dotnet_naming_style.pascal_case.word_separator = +dotnet_naming_style.pascal_case.capitalization = pascal_case + +dotnet_naming_style.begins_with_i.required_prefix = I +dotnet_naming_style.begins_with_i.required_suffix = +dotnet_naming_style.begins_with_i.word_separator = +dotnet_naming_style.begins_with_i.capitalization = pascal_case diff --git a/subprojects/gstreamer-sharp/gstreamer-sharp.sln b/subprojects/gstreamer-sharp/gstreamer-sharp.sln index 15d78f301b..d719203fa0 100644 --- a/subprojects/gstreamer-sharp/gstreamer-sharp.sln +++ b/subprojects/gstreamer-sharp/gstreamer-sharp.sln @@ -3,6 +3,11 @@ Microsoft Visual Studio Solution File, Format Version 11.00 # Visual Studio 2010 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "gstreamer-sharp", "gstreamer-sharp.csproj", "{64358320-CAC2-4B22-836C-268269DAB031}" EndProject +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{450AC3AE-83DF-42C0-A7FD-4A4ADD3243FF}" + ProjectSection(SolutionItems) = preProject + .editorconfig = .editorconfig + EndProjectSection +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|Any CPU = Debug|Any CPU