mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-06-02 08:29:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

videoconvertscale: ensure writable caps when fixating format

Browse source 
gst_video_convert_scale_get_fixed_format() receives 'othercaps' from
basetransforms' fixate_caps() vmethod which explicitly mentions that
'`othercaps` may not be writable'.

The gst_caps_intersect() call just before may or may not produce new
caps. Particularly in cases like EMPTY or ANY caps on either of the
inputs, only a ref is taken and returned to the caller.

As a result, gst_video_convert_scale_fixate_format() may have attempted
to modify a non-writable caps structure.

Fix by adding a gst_caps_make_writable().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2709>
This commit is contained in:
Matthew Waters 2022-07-04 17:27:50 +10:00 committed by GStreamer Marge Bot
parent 339f950e79
commit dd4bbb6379
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
subprojects/gst-plugins-base/gst/videoconvertscale/gstvideoconvertscale.c
View file

@ -1249,6 +1249,7 @@ gst_video_convert_scale_get_fixed_format (GstBaseTransform * trans,
result = gst_caps_copy (othercaps);
}
result = gst_caps_make_writable (result);
gst_video_convert_scale_fixate_format (trans, caps, result);
/* fixate remaining fields */