mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-05-18 00:12:46 +00:00
Code Issues Projects Releases Wiki Activity

tests: remove silly test_fail_abstract_new check

Browse source 
Our check would make sure that GLib segfaults when
someone tries to instantiate an abstract type, which
is an extremely useful thing to check for.

In newer GLibs this is fixed and we get an abort with
a g_error() now it seems, so let's just remove this
check entirely.
This commit is contained in:
Tim-Philipp Müller 2012-08-08 14:49:23 +01:00 committed by Tim-Philipp Müller
parent 60516f4798
commit 76fc67b18c
1 changed files with 0 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
tests/check/gst/gstobject.c
View file

@ -72,19 +72,6 @@ gst_fake_object_get_type (void)
return fake_object_type;
}
#ifndef HAVE_OSX
/* g_object_new on abstract GstObject should fail */
GST_START_TEST (test_fail_abstract_new)
{
GstObject *object;
ASSERT_CRITICAL (object = g_object_new (gst_object_get_type (), NULL));
fail_unless (object == NULL, "Created an instance of abstract GstObject");
}
GST_END_TEST;
#endif
/* g_object_new on GstFakeObject should succeed */
GST_START_TEST (test_fake_object_new)
{
@ -529,18 +516,6 @@ gst_object_suite (void)
tcase_add_test (tc_chain, test_fake_object_has_ancestor);
//tcase_add_checked_fixture (tc_chain, setup, teardown);
/* FIXME: GLib shouldn't crash here, but issue a warning and return a NULL
* object, or at least g_error() and then abort properly ... (tpm) */
#ifndef HAVE_OSX
/* Disabled for OS/X because a) it's a pretty silly test anyway and
* b) different OS/X versions raise different signals and it isn't worth
* the effort to try and detect which one should be producing which
*/
/* SEGV tests go last so we can debug the others */
if (g_getenv ("CK_FORK") == NULL || strcmp (g_getenv ("CK_FORK"), "no") != 0)
tcase_add_test_raise_signal (tc_chain, test_fail_abstract_new, SIGSEGV);
#endif
return s;
}