diff --git a/ChangeLog b/ChangeLog index 3c286084df..cbedc798a8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2004-02-22 Thomas Vander Stichele + + * gst/elements/gstfilesink.c: (gst_filesink_open_file): + * gst/elements/gstfilesrc.c: (gst_filesrc_open_file): + * gst/elements/gstmultifilesrc.c: (gst_multifilesrc_open_file): + 2004-02-20 Andy Wingo * gst/gstbin.c: diff --git a/gst/elements/gstfilesink.c b/gst/elements/gstfilesink.c index 66d7f0f738..fb575cdc68 100644 --- a/gst/elements/gstfilesink.c +++ b/gst/elements/gstfilesink.c @@ -242,10 +242,10 @@ gst_filesink_open_file (GstFileSink *sink) g_return_val_if_fail (!GST_FLAG_IS_SET (sink, GST_FILESINK_OPEN), FALSE); /* open the file */ - if (!sink->filename) + if (sink->filename == NULL || sink->filename[0] == '\0') { GST_ELEMENT_ERROR (sink, RESOURCE, NOT_FOUND, - (_("No filename specified.")), (NULL)); + (_("No file name specified for writing.")), (NULL)); return FALSE; } diff --git a/gst/elements/gstfilesrc.c b/gst/elements/gstfilesrc.c index f32ae0d96c..7882e9866b 100644 --- a/gst/elements/gstfilesrc.c +++ b/gst/elements/gstfilesrc.c @@ -670,17 +670,10 @@ gst_filesrc_open_file (GstFileSrc *src) { g_return_val_if_fail (!GST_FLAG_IS_SET (src ,GST_FILESRC_OPEN), FALSE); - if (src->filename == NULL) + if (src->filename == NULL || src->filename[0] == '\0') { GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, - (_("No filename specified.")), (NULL)); - return FALSE; - } - - if (src->filename == NULL) - { - GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, - (_("No file specified for reading.")), (NULL)); + (_("No file name specified for reading.")), (NULL)); return FALSE; } diff --git a/gst/elements/gstmultifilesrc.c b/gst/elements/gstmultifilesrc.c index 248e4b3a64..454acf6009 100644 --- a/gst/elements/gstmultifilesrc.c +++ b/gst/elements/gstmultifilesrc.c @@ -236,9 +236,15 @@ gboolean gst_multifilesrc_open_file (GstMultiFileSrc *src, GstPad *srcpad) { g_return_val_if_fail (!GST_FLAG_IS_SET (src, GST_MULTIFILESRC_OPEN), FALSE); + if (src->currentfilename == NULL || src->currentfilename[0] == '\0') + { + GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, + (_("No file name specified for reading.")), (NULL)); + return FALSE; + } + /* open the file */ src->fd = open ((const char *) src->currentfilename, O_RDONLY); - if (src->fd < 0) { GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, (_("Could not open file \"%s\" for reading."), src->currentfilename), diff --git a/plugins/elements/gstfilesink.c b/plugins/elements/gstfilesink.c index 66d7f0f738..fb575cdc68 100644 --- a/plugins/elements/gstfilesink.c +++ b/plugins/elements/gstfilesink.c @@ -242,10 +242,10 @@ gst_filesink_open_file (GstFileSink *sink) g_return_val_if_fail (!GST_FLAG_IS_SET (sink, GST_FILESINK_OPEN), FALSE); /* open the file */ - if (!sink->filename) + if (sink->filename == NULL || sink->filename[0] == '\0') { GST_ELEMENT_ERROR (sink, RESOURCE, NOT_FOUND, - (_("No filename specified.")), (NULL)); + (_("No file name specified for writing.")), (NULL)); return FALSE; } diff --git a/plugins/elements/gstfilesrc.c b/plugins/elements/gstfilesrc.c index f32ae0d96c..7882e9866b 100644 --- a/plugins/elements/gstfilesrc.c +++ b/plugins/elements/gstfilesrc.c @@ -670,17 +670,10 @@ gst_filesrc_open_file (GstFileSrc *src) { g_return_val_if_fail (!GST_FLAG_IS_SET (src ,GST_FILESRC_OPEN), FALSE); - if (src->filename == NULL) + if (src->filename == NULL || src->filename[0] == '\0') { GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, - (_("No filename specified.")), (NULL)); - return FALSE; - } - - if (src->filename == NULL) - { - GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, - (_("No file specified for reading.")), (NULL)); + (_("No file name specified for reading.")), (NULL)); return FALSE; } diff --git a/plugins/elements/gstmultifilesrc.c b/plugins/elements/gstmultifilesrc.c index 248e4b3a64..454acf6009 100644 --- a/plugins/elements/gstmultifilesrc.c +++ b/plugins/elements/gstmultifilesrc.c @@ -236,9 +236,15 @@ gboolean gst_multifilesrc_open_file (GstMultiFileSrc *src, GstPad *srcpad) { g_return_val_if_fail (!GST_FLAG_IS_SET (src, GST_MULTIFILESRC_OPEN), FALSE); + if (src->currentfilename == NULL || src->currentfilename[0] == '\0') + { + GST_ELEMENT_ERROR (src, RESOURCE, NOT_FOUND, + (_("No file name specified for reading.")), (NULL)); + return FALSE; + } + /* open the file */ src->fd = open ((const char *) src->currentfilename, O_RDONLY); - if (src->fd < 0) { GST_ELEMENT_ERROR (src, RESOURCE, OPEN_READ, (_("Could not open file \"%s\" for reading."), src->currentfilename),