mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-06-02 07:00:52 +00:00
Code Issues 1 Projects Releases Wiki Activity

devicemonitor: Use a sync bus handler for the provider to avoid accumulating all messages until the provider is stopped

Browse source 
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/981

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2741>
This commit is contained in:
Sebastian Dröge 2022-07-09 18:05:58 +03:00 committed by GStreamer Marge Bot
parent ab459f0528
commit 47ac79d7b8
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
subprojects/gstreamer/gst/gstdevicemonitor.c
View file

@ -257,7 +257,7 @@ update_hidden_providers_list (GList ** hidden, GstDeviceProvider * provider)
}
}
static void
static GstBusSyncReply
bus_sync_message (GstBus * bus, GstMessage * message,
GstDeviceMonitor * monitor)
{
@ -305,6 +305,10 @@ bus_sync_message (GstBus * bus, GstMessage * message,
if (matches)
gst_bus_post (monitor->priv->bus, gst_message_ref (message));
}
gst_message_unref (message);
return GST_BUS_DROP;
}
@ -335,7 +339,7 @@ gst_device_monitor_remove_provider (GstDeviceMonitor * self, guint i)
g_ptr_array_remove_index (self->priv->providers, i);
bus = gst_device_provider_get_bus (provider);
g_signal_handlers_disconnect_by_func (bus, bus_sync_message, self);
gst_bus_set_sync_handler (bus, NULL, NULL, NULL);
gst_object_unref (bus);
g_signal_handlers_disconnect_by_func (provider, provider_hidden, self);
@ -703,9 +707,8 @@ gst_device_monitor_add_filter_unlocked (GstDeviceMonitor * monitor,
(GCallback) provider_unhidden, monitor);
matched = TRUE;
gst_bus_enable_sync_message_emission (bus);
g_signal_connect (bus, "sync-message",
G_CALLBACK (bus_sync_message), monitor);
gst_bus_set_sync_handler (bus, (GstBusSyncHandler) bus_sync_message,
monitor, NULL);
gst_object_unref (bus);
g_ptr_array_add (monitor->priv->providers, provider);
}