From 42717a30f83867f0fcb95eb66c17c854c4ea53d5 Mon Sep 17 00:00:00 2001 From: Xavier Claessens Date: Sat, 16 Sep 2023 09:25:46 -0400 Subject: [PATCH] Meson: Set some options back to auto by default Some options got enabled by default since that commit: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/40371ff9c678422f99ddfc0c80b9254a2f203afd While the commit message example makes perfect sense to enable `bad` by default, I don't think the same reasoning applies to libav, devtools, ges and rtsp_server. I think it is important to keep a build with `-Dauto_features=disabled` minimal, especially not pulling external dependencies. For example, with libav being enabled by default, Meson builds FFmpeg subproject even when disabling auto features. It is fine to keep `bad` enabled by default because itself has auto features for every plugins, when auto features are disabled it only build libraries that does not have external deps. Part-of: --- meson_options.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index 276e0e807f..df7bac3643 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -3,10 +3,10 @@ option('base', type : 'feature', value : 'enabled') option('good', type : 'feature', value : 'enabled') option('ugly', type : 'feature', value : 'enabled') option('bad', type : 'feature', value : 'enabled') -option('libav', type : 'feature', value : 'enabled') -option('devtools', type : 'feature', value : 'enabled') -option('ges', type : 'feature', value : 'enabled') -option('rtsp_server', type : 'feature', value : 'enabled') +option('libav', type : 'feature', value : 'auto') +option('devtools', type : 'feature', value : 'auto') +option('ges', type : 'feature', value : 'auto') +option('rtsp_server', type : 'feature', value : 'auto') option('rs', type : 'feature', value : 'disabled') option('vaapi', type : 'feature', value : 'disabled') option('gst-examples', type : 'feature', value : 'auto', description : 'Build gst-examples subproject')