From 37c7c92c033426f7a5b8c567ede727c1d8b9aacc Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Sat, 24 Jun 2023 01:43:50 +0900 Subject: [PATCH] dwritetimeoverlay: Fix member variable initialization Use GstBaseTransform::start() instead Part-of: --- .../gst-plugins-bad/sys/dwrite/gstdwritebaseoverlay.h | 2 -- .../sys/dwrite/gstdwritetimeoverlay.cpp | 10 +++++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/subprojects/gst-plugins-bad/sys/dwrite/gstdwritebaseoverlay.h b/subprojects/gst-plugins-bad/sys/dwrite/gstdwritebaseoverlay.h index 93f9b99a29..eaaddc8d3f 100644 --- a/subprojects/gst-plugins-bad/sys/dwrite/gstdwritebaseoverlay.h +++ b/subprojects/gst-plugins-bad/sys/dwrite/gstdwritebaseoverlay.h @@ -57,8 +57,6 @@ struct _GstDWriteBaseOverlayClass gboolean (*sink_event) (GstDWriteBaseOverlay * overlay, GstEvent * event); - gboolean (*start) (GstDWriteBaseOverlay * overlay); - WString (*get_text) (GstDWriteBaseOverlay * overlay, const std::wstring & default_text, GstBuffer * buffer); diff --git a/subprojects/gst-plugins-bad/sys/dwrite/gstdwritetimeoverlay.cpp b/subprojects/gst-plugins-bad/sys/dwrite/gstdwritetimeoverlay.cpp index 46fd7ceefa..5e43f90df8 100644 --- a/subprojects/gst-plugins-bad/sys/dwrite/gstdwritetimeoverlay.cpp +++ b/subprojects/gst-plugins-bad/sys/dwrite/gstdwritetimeoverlay.cpp @@ -129,7 +129,7 @@ static void gst_dwrite_time_overlay_get_property (GObject * object, guint prop_id, GValue * value, GParamSpec * pspec); static gboolean gst_dwrite_time_overlay_sink_event (GstBaseTransform * trans, GstEvent * event); -static gboolean gst_dwrite_time_overlay_start (GstDWriteBaseOverlay * overlay); +static gboolean gst_dwrite_time_overlay_start (GstBaseTransform * overlay); static WString gst_dwrite_time_overlay_get_text (GstDWriteBaseOverlay * overlay, const WString & default_text, GstBuffer * buffer); @@ -185,7 +185,7 @@ gst_dwrite_time_overlay_class_init (GstDWriteTimeOverlayClass * klass) trans_class->sink_event = GST_DEBUG_FUNCPTR (gst_dwrite_time_overlay_sink_event); - overlay_class->start = GST_DEBUG_FUNCPTR (gst_dwrite_time_overlay_start); + trans_class->start = GST_DEBUG_FUNCPTR (gst_dwrite_time_overlay_start); overlay_class->get_text = GST_DEBUG_FUNCPTR (gst_dwrite_time_overlay_get_text); @@ -284,15 +284,15 @@ gst_dwrite_time_overlay_get_property (GObject * object, guint prop_id, } static gboolean -gst_dwrite_time_overlay_start (GstDWriteBaseOverlay * overlay) +gst_dwrite_time_overlay_start (GstBaseTransform * trans) { - GstDWriteTimeOverlay *self = GST_DWRITE_TIME_OVERLAY (overlay); + GstDWriteTimeOverlay *self = GST_DWRITE_TIME_OVERLAY (trans); GstDWriteTimeOverlayPrivate *priv = self->priv; priv->first_running_time = GST_CLOCK_TIME_NONE; priv->buffer_count = 0; - return TRUE; + return GST_BASE_TRANSFORM_CLASS (parent_class)->start (trans); } static gboolean