mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-06-08 17:19:25 +00:00
Code Issues 1 Projects Releases Wiki Activity

videodecoder: Use a frame duration for QoS

Browse source 
We prefer to use the frame stop position for checking for QoS since we don't
want to drop a frame which is only partially late.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6689>
This commit is contained in:
Edward Hervey 2024-04-19 11:32:47 +02:00 committed by GStreamer Marge Bot
parent a7d0b07406
commit 2aba1c86e9
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
subprojects/gst-plugins-base/gst-libs/gst/video/gstvideodecoder.c
View file

@ -3652,11 +3652,15 @@ gst_video_decoder_clip_and_push_buf (GstVideoDecoder * decoder, GstBuffer * buf)
goto done; goto done;
} }
/* Is buffer too late (QoS) ? */ /* Check if the buffer is too late (QoS). */
if (priv->do_qos && GST_CLOCK_TIME_IS_VALID (priv->earliest_time) if (priv->do_qos && GST_CLOCK_TIME_IS_VALID (priv->earliest_time)) {
&& GST_CLOCK_TIME_IS_VALID (cstart)) { GstClockTime deadline = GST_CLOCK_TIME_NONE;
GstClockTime deadline = /* We prefer to use the frame stop position for checking for QoS since we
gst_segment_to_running_time (segment, GST_FORMAT_TIME, cstart); * don't want to drop a frame which is partially late */
if (GST_CLOCK_TIME_IS_VALID (cstop))
deadline = gst_segment_to_running_time (segment, GST_FORMAT_TIME, cstop);
else if (GST_CLOCK_TIME_IS_VALID (cstart))
deadline = gst_segment_to_running_time (segment, GST_FORMAT_TIME, cstart);
if (GST_CLOCK_TIME_IS_VALID (deadline) && deadline < priv->earliest_time) { if (GST_CLOCK_TIME_IS_VALID (deadline) && deadline < priv->earliest_time) {
GST_WARNING_OBJECT (decoder, GST_WARNING_OBJECT (decoder,
"Dropping frame due to QoS. start:%" GST_TIME_FORMAT " deadline:%" "Dropping frame due to QoS. start:%" GST_TIME_FORMAT " deadline:%"