From cf32d9d66815fb230d3507702c57ce776feebd1c Mon Sep 17 00:00:00 2001 From: Thibault Saunier Date: Wed, 8 Mar 2023 11:15:53 -0300 Subject: [PATCH] webrtc: Move make_element to the utils Part-of: --- net/webrtc/src/utils.rs | 13 +++++++++++++ net/webrtc/src/webrtcsink/imp.rs | 13 ------------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/net/webrtc/src/utils.rs b/net/webrtc/src/utils.rs index b9026506..d89e9e22 100644 --- a/net/webrtc/src/utils.rs +++ b/net/webrtc/src/utils.rs @@ -85,3 +85,16 @@ pub fn serialize_json_object(val: &serde_json::Map) - res } + +/// Wrapper around `gst::ElementFactory::make` with a better error +/// message +pub fn make_element(element: &str, name: Option<&str>) -> Result { + let mut builder = gst::ElementFactory::make(element); + if let Some(name) = name { + builder = builder.name(name); + } + + builder + .build() + .with_context(|| format!("Failed to make element {element}")) +} diff --git a/net/webrtc/src/webrtcsink/imp.rs b/net/webrtc/src/webrtcsink/imp.rs index 4c58ec6a..1c99f233 100644 --- a/net/webrtc/src/webrtcsink/imp.rs +++ b/net/webrtc/src/webrtcsink/imp.rs @@ -261,19 +261,6 @@ fn create_navigation_event(sink: &super::BaseWebRTCSink, msg: &str) { } } -/// Wrapper around `gst::ElementFactory::make` with a better error -/// message -fn make_element(element: &str, name: Option<&str>) -> Result { - let mut builder = gst::ElementFactory::make(element); - if let Some(name) = name { - builder = builder.name(name); - } - - builder - .build() - .with_context(|| format!("Failed to make element {element}")) -} - /// Simple utility for tearing down a pipeline cleanly struct PipelineWrapper(gst::Pipeline);