mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-06-02 07:22:41 +00:00
Code Issues Projects Releases Wiki Activity

Respect user provided max-bitrate when congestion controler is disabled

Browse source
This commit is contained in:
Thibault Saunier 2021-12-03 13:21:16 +00:00 committed by Mathieu Duponchelle
parent 5904e1ccb4
commit b12d91775d
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
plugins/src/webrtcsink/imp.rs
View file

@ -32,6 +32,10 @@ const RTP_TWCC_URI: &str =
const DEFAULT_STUN_SERVER: Option<&str> = Some("stun://stun.l.google.com:19302");
const DEFAULT_MIN_BITRATE: u32 = 1000;
/* I have found higher values to cause packet loss *somewhere* in
* my local network, possibly related to chrome's pretty low UDP
* buffer sizes */
const DEFAULT_MAX_BITRATE: u32 = 8192000;
const DEFAULT_CONGESTION_CONTROL: WebRTCSinkCongestionControl =
WebRTCSinkCongestionControl::Homegrown;
@ -154,6 +158,8 @@ struct Consumer {
congestion_controller: Option<CongestionController>,
sdp: Option<gst_sdp::SDPMessage>,
stats: gst::Structure,
max_bitrate: u32,
}
#[derive(PartialEq)]
@ -953,12 +959,8 @@ impl Consumer {
/* If congestion control is disabled, we simply use the highest
* known "safe" value for the bitrate.
*
* I have found higher values to cause packet loss *somewhere* in
* my local network, possibly related to chrome's pretty low UDP
* buffer sizes, this probably should be exposed as a property
* eventually.
*/
enc.set_bitrate(element, 8192000i32);
enc.set_bitrate(element, self.max_bitrate as i32);
}
self.encoders.push(enc);
@ -1464,6 +1466,7 @@ impl WebRTCSink {
encoders: Vec::new(),
sdp: None,
stats: gst::Structure::new_empty("application/x-webrtc-stats"),
max_bitrate: settings.max_bitrate,
};
state