From 785c9557c8d66c8f1048c2a5fdf481115436e0ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Laignel?= <francois@centricular.com>
Date: Mon, 18 Sep 2023 17:01:07 +0200
Subject: [PATCH] net/webrtcsink: drop State lock before calling
 set-local-description

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1325>
---
 net/webrtc/src/webrtcsink/imp.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/webrtc/src/webrtcsink/imp.rs b/net/webrtc/src/webrtcsink/imp.rs
index ca4b393c..74a16907 100644
--- a/net/webrtc/src/webrtcsink/imp.rs
+++ b/net/webrtc/src/webrtcsink/imp.rs
@@ -1839,12 +1839,13 @@ impl BaseWebRTCSink {
                     .and_then(|format| format.parse::<i32>().ok());
             }
 
-            // FIXME I think the intention was to drop(state) and re-acquire the lock after the call
+            drop(state);
 
             session
                 .webrtcbin
                 .emit_by_name::<()>("set-local-description", &[&answer, &None::<gst::Promise>]);
 
+            let mut state = self.state.lock().unwrap();
             let session_id = session.id.clone();
 
             if let Some(session_wrapper) = state.sessions.get_mut(&session_id) {