mirror of
https://github.com/bookwyrm-social/bookwyrm.git
synced 2024-05-18 08:23:05 +00:00
6684d60526
As outlined in #3354, a use `Move` fails if the user is moving from a BookWyrm server to another BookWrym server. This is because: 1. the original code did not announce changes to alsoKnownAs; 2. the original code always checked the locally saved profile rather than refetching the remote data; This commit fixes both these problems by forcing `MoveUser` to always perform a "refresh" of the local data from the remote, and by saving the user with broadcast=True when updating alsoKnownAs ids.
72 lines
2 KiB
Python
72 lines
2 KiB
Python
""" move an object including migrating a user account """
|
|
from django.core.exceptions import PermissionDenied
|
|
from django.db import models
|
|
|
|
from bookwyrm import activitypub
|
|
from .activitypub_mixin import ActivityMixin
|
|
from .base_model import BookWyrmModel
|
|
from . import fields
|
|
from .notification import Notification, NotificationType
|
|
|
|
|
|
class Move(ActivityMixin, BookWyrmModel):
|
|
"""migrating an activitypub object"""
|
|
|
|
user = fields.ForeignKey(
|
|
"User", on_delete=models.PROTECT, activitypub_field="actor"
|
|
)
|
|
|
|
object = fields.CharField(
|
|
max_length=255,
|
|
blank=False,
|
|
null=False,
|
|
activitypub_field="object",
|
|
)
|
|
|
|
origin = fields.CharField(
|
|
max_length=255,
|
|
blank=True,
|
|
null=True,
|
|
default="",
|
|
activitypub_field="origin",
|
|
)
|
|
|
|
activity_serializer = activitypub.Move
|
|
|
|
|
|
class MoveUser(Move):
|
|
"""migrating an activitypub user account"""
|
|
|
|
target = fields.ForeignKey(
|
|
"User",
|
|
on_delete=models.PROTECT,
|
|
related_name="move_target",
|
|
activitypub_field="target",
|
|
)
|
|
|
|
def save(self, *args, **kwargs):
|
|
"""update user info and broadcast it"""
|
|
|
|
# only allow if the source is listed in the target's alsoKnownAs
|
|
if self.user in self.target.also_known_as.all():
|
|
self.user.also_known_as.add(self.target.id)
|
|
self.user.update_active_date()
|
|
self.user.moved_to = self.target.remote_id
|
|
self.user.save(update_fields=["moved_to"])
|
|
|
|
if self.user.local:
|
|
kwargs[
|
|
"broadcast"
|
|
] = True # Only broadcast if we are initiating the Move
|
|
|
|
super().save(*args, **kwargs)
|
|
|
|
for follower in self.user.followers.all():
|
|
if follower.local:
|
|
Notification.notify(
|
|
follower, self.user, notification_type=NotificationType.MOVE
|
|
)
|
|
|
|
else:
|
|
raise PermissionDenied()
|