Commit graph

20 commits

Author SHA1 Message Date
Bart Schuurmans ffee29d8e2 Fix resource leaks
Rewrite places where files (or other resources) are opened but not closed to "with" blocks, which
automatically call close() at the end of the scope.

Also simplify some tests where images need to be saved to a model field: an opened file can be
passed directly to FileField.save().
2024-03-29 20:14:10 +01:00
Adeodato Simó e2c9ea3cd2 Fix instances of bad-classmethod-argument in recently edited files 2024-03-17 21:28:55 -03:00
Adeodato Simó 1b9e0546e6 Bracket-wrap calls to patch() for better readability 2024-03-17 20:34:12 -03:00
Adeodato Simó 9d502f5ee2
Use setUpTestData() to speed up tests
Pylint's `bad-classmethod-argument` is disabled for each definition
to avoid rewriting the method bodies just to rename `self` → `cls`.
This can be done gradually, as the setUpTestData methods are modified
along the way.
2023-12-11 19:40:30 -03:00
Mouse Reeve d4351cfcb4
Merge branch 'main' into import-limit 2022-12-16 12:44:57 -08:00
Giebisch df54df8309 Added Import Limit 2022-12-15 23:43:25 +01:00
Rick Osborne 862260294a
StoryGraph import ISBN tweak
Looks like SG updated their CSV headers just a little, so that the importer
hadn't been picking up the ISBN.
2022-12-02 19:16:22 -08:00
Mouse Reeve 141d3aa813 Updates mocks in tests 2022-11-07 09:50:05 -08:00
André Jaenisch 62c7661fb9
Reformat tests using black
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
2022-05-05 21:31:56 +02:00
André Jaenisch 6bd9b725e2
Refactor hard-coded strings with a reference to a static property
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
2022-05-05 13:07:25 +02:00
Mouse Reeve 975ef7d38e Merge branch 'main' into list-not-loading 2021-12-30 10:44:23 -08:00
Mouse Reeve a9ff23ece0 Fixes nondeterministic test failure 2021-12-29 13:44:04 -08:00
Mouse Reeve acde30887d Importer tests 2021-12-09 20:12:06 -08:00
Mouse Reeve 232e051dcb Fixes import job creates in tests 2021-11-13 10:16:05 -08:00
Mouse Reeve d3f23b4a0a Updates calls in tests 2021-11-13 09:50:56 -08:00
Mouse Reeve b784dcdb46 Removes uninformative test 2021-11-12 15:07:26 -08:00
Mouse Reeve e6a251fdad Updates mocks across tests 2021-11-12 10:07:38 -08:00
Mouse Reeve efcf7824dd iUpdates storygraph tests 2021-11-11 12:39:12 -08:00
Mouse Reeve 20baf9385d Updates goodreads tests 2021-11-11 09:22:44 -08:00
Mouse Reeve 1b9d08414f Adds storygraph tests 2021-11-10 09:55:52 -08:00