From 4c0d5ede8618d34e3d5e964e842a405d3019e776 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=B8ren=20Birkemeyer?= <sb@webfactory.de>
Date: Sat, 10 Feb 2024 16:24:49 +0000
Subject: [PATCH] Fix label and input association for shelves filter

This PR correctly associates label and text input of the shelves
filter via for- and id-attributes. With the association in place,
the aria-label can be removed (the label will be announced by
assistive software when the input is focused). This also fixes the
issue that the aria-label was not translated, whereas the label is.
---
 bookwyrm/templates/shelf/shelves_filter_field.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bookwyrm/templates/shelf/shelves_filter_field.html b/bookwyrm/templates/shelf/shelves_filter_field.html
index 707f033ea..53c551d13 100644
--- a/bookwyrm/templates/shelf/shelves_filter_field.html
+++ b/bookwyrm/templates/shelf/shelves_filter_field.html
@@ -3,7 +3,7 @@
 
 {% block filter %}
   <div class="control">
-    <label class="label" for="filter_query">{% trans 'Filter by keyword' %}</label>
-    <input aria-label="Filter by keyword" id="my-books-filter" class="input" type="text" name="filter" placeholder="{% trans 'Enter text here' %}" value="{{ shelves_filter_query|default:'' }}" spellcheck="false" />
+    <label class="label" for="my-books-filter">{% trans 'Filter by keyword' %}</label>
+    <input id="my-books-filter" class="input" type="text" name="filter" placeholder="{% trans 'Enter text here' %}" value="{{ shelves_filter_query|default:'' }}" spellcheck="false" />
   </div>
 {% endblock %}