diff --git a/fedireads/federation.py b/fedireads/federation.py index 77a7ac27f..45a352964 100644 --- a/fedireads/federation.py +++ b/fedireads/federation.py @@ -191,16 +191,18 @@ def handle_outgoing_follow(user, to_follow): def handle_response(response): ''' hopefully it's an accept from our follow request ''' - activity = response.json() - if not activity: + try: + activity = response.json() + except ValueError: return if activity['type'] == 'Accept': handle_incoming_accept(activity) def handle_incoming_accept(activity): ''' someone is accepting a follow request ''' - # remote user who said yes + # not actually a remote user so this is kinda janky user = get_or_create_remote_user(activity['actor']) + # the person our local user wants to follow, who said yes followed = models.User.objects.get(actor=activity['object']['actor']) followed.followers.add(user) models.FollowActivity( diff --git a/fedireads/templates/book.html b/fedireads/templates/book.html index aabe0730d..35fc512dc 100644 --- a/fedireads/templates/book.html +++ b/fedireads/templates/book.html @@ -17,6 +17,9 @@

Reviews

+ {% if not reviews %} +

No reviews yet!

+ {% endif %} {% for review in reviews %}

{{ review.name }}{{ review.rating }} stars, by {{ review.user.username }}

{{ review.review_content }}

diff --git a/fedireads/templates/feed.html b/fedireads/templates/feed.html index 9c7b56915..55460b8a4 100644 --- a/fedireads/templates/feed.html +++ b/fedireads/templates/feed.html @@ -26,7 +26,7 @@

by {{ book.authors.first.data.name }}

{% if not book.user_shelves %} -
+
@@ -38,7 +38,9 @@
{% endfor %}