From 474b78dad2eabd509ddf16d4d84be9bac91dc16b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olivier=20Brenckl=C3=A9?= Date: Mon, 24 Oct 2022 19:34:25 +0200 Subject: [PATCH 1/2] :lipstick: Set dropdown menu below modals on mobile --- bookwyrm/static/css/bookwyrm/components/_details.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bookwyrm/static/css/bookwyrm/components/_details.scss b/bookwyrm/static/css/bookwyrm/components/_details.scss index c9a0b33b8..de29629c8 100644 --- a/bookwyrm/static/css/bookwyrm/components/_details.scss +++ b/bookwyrm/static/css/bookwyrm/components/_details.scss @@ -67,7 +67,7 @@ details.dropdown .dropdown-menu a:focus-visible { align-items: center; justify-content: center; pointer-events: none; - z-index: 100; + z-index: 35; } details .dropdown-menu > * { From cfaec434c055690c1387beb434ae3d7af3e616ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olivier=20Brenckl=C3=A9?= Date: Thu, 27 Oct 2022 14:04:22 +0200 Subject: [PATCH 2/2] :children_crossing: Close dropdown when opening modal item --- bookwyrm/static/js/bookwyrm.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/bookwyrm/static/js/bookwyrm.js b/bookwyrm/static/js/bookwyrm.js index 95271795d..aa06a8b0a 100644 --- a/bookwyrm/static/js/bookwyrm.js +++ b/bookwyrm/static/js/bookwyrm.js @@ -38,11 +38,12 @@ let BookWyrm = new (class { .querySelectorAll("[data-modal-open]") .forEach((node) => node.addEventListener("click", this.handleModalButton.bind(this))); - document - .querySelectorAll("details.dropdown") - .forEach((node) => - node.addEventListener("toggle", this.handleDetailsDropdown.bind(this)) + document.querySelectorAll("details.dropdown").forEach((node) => { + node.addEventListener("toggle", this.handleDetailsDropdown.bind(this)); + node.querySelectorAll("[data-modal-open]").forEach((modal_node) => + modal_node.addEventListener("click", () => (node.open = false)) ); + }); document .querySelector("#barcode-scanner-modal")